[PING] Re: [PATCH] Fix PR92088
Joseph Myers
joseph@codesourcery.com
Tue Nov 19 22:19:00 GMT 2019
On Tue, 19 Nov 2019, Richard Biener wrote:
> > + /* For nested functions disqualify ones taking VLAs by value
> > + from inlining since the middle-end cannot deal with this.
> > + ??? We should arrange for those to be passed by reference
> > + with emitting the copy on the caller side in the frontend. */
> > + if (storage_class == csc_none
> > + && TREE_CODE (type) == FUNCTION_TYPE)
> > + for (tree al = TYPE_ARG_TYPES (type); al; al = TREE_CHAIN (al))
> > + {
> > + tree arg = TREE_VALUE (al);
> > + if (arg != error_mark_node
> > + && C_TYPE_VARIABLE_SIZE (TREE_VALUE (al)))
The second use of TREE_VALUE (al) looks like it would be better as a
reference to arg. OK with that change.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Gcc-patches
mailing list