V2 [PATCH] i386: Insert ENDBR for NOTE_INSN_DELETED_LABEL only if needed

Jakub Jelinek jakub@redhat.com
Tue May 28 09:22:00 GMT 2019


On Sat, Feb 16, 2019 at 07:02:11AM -0800, H.J. Lu wrote:
> > For NOTE_INSN_DELETED_LABEL, we should check if forced_labels to see
> > if its address is taken.  Also ix86_init_large_pic_reg shouldn't set
> > LABEL_PRESERVE_P (in_struct) since NOTE_INSN_DELETED_LABEL is suffcient
> > to keep the label.

Can you explain when is it ever needed to emit ENDBR on
NOTE_INSN_DELETED_LABEL?  Only labels that are proven not to be ever
branched to are turned into deleted labels, so I think the right answer is
never emit any ENDBR on those...

	Jakub



More information about the Gcc-patches mailing list