[C++ PATCH] Using decls

[Marek Polacek]

Thanks for the patch and sorry for nitpicking:

On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote:
> -/* Process a local-scope or namespace-scope using declaration.  SCOPE
> +/* Process a local-scope or namespace-scope using declaration.
> +   FIXME

This ain't look right.  You meant to document the INSERT_P param, right.

> +      /* DR 36 questions why using-decls at function scope may not be
> +	 duplicates.  Disallow it, as C++11 claimed and PR 20420
> +	 implemented.  */
> +      do_nonmember_using_decl (lookup, true, true, &value, &type);
> +
> +      if (!value)
> +	;
> +      else if (binding && value == binding->value)
> +	;
> +      else if (binding && binding->value && TREE_CODE (value) == OVERLOAD)
> +	{
> +	  update_local_overload (IDENTIFIER_BINDING (name), value);
> +	  IDENTIFIER_BINDING (name)->value = value;
> +	}
> +      else
> +	/* Install the new binding.  */
> +	// FIXME: Short circuit P_L_B

Was this FIXME meant to be here?

Marek