[PATCH] Strip target_clones in copy attribute (PR lto/90500).
Iain Sandoe
idsandoe@googlemail.com
Tue May 21 09:57:00 GMT 2019
> On 21 May 2019, at 10:48, Martin Liška <mliska@suse.cz> wrote:
>
> On 5/21/19 11:41 AM, Dominique d'Humières wrote:
>> Hi Martin,
>>
>> /* { dg-require-ifunc } */
>>
>> should be
>>
>> /* { dg-require-ifunc ""} */
>>
>> and the same for pr90500-2.c (see https://gcc.gnu.org/ml/gcc-patches/2019-05/msg01152.html)
>>
>> TIA
>>
>> Dominique
>>
> Thanks, should I fix it for all:
>
> gcc/testsuite/gcc.target/i386/pr84723-1.c:/* { dg-require-ifunc } */
> gcc/testsuite/gcc.target/i386/pr84723-2.c:/* { dg-require-ifunc } */
> gcc/testsuite/gcc.target/i386/pr84723-3.c:/* { dg-require-ifunc } */
> gcc/testsuite/gcc.target/i386/pr84723-4.c:/* { dg-require-ifunc } */
> gcc/testsuite/gcc.target/i386/pr84723-5.c:/* { dg-require-ifunc } */
as noted in the thread referenced, if there is some benefit in running these ^^
tests on a non-ifunc target, then the line should be removed - otherwise
yes, fix it so that these targets don’t run it by accident.
> gcc/testsuite/gcc.target/i386/pr90500-1.c:/* { dg-require-ifunc } */
> gcc/testsuite/gcc.target/i386/pr90500-2.c:/* { dg-require-ifunc } */
yes.
thanks
Iain
More information about the Gcc-patches
mailing list