[committed] Clean up MPX-related stuff: CIF_CHKP

Martin Liška mliska@suse.cz
Thu May 9 10:04:00 GMT 2019


On 5/9/19 11:59 AM, Thomas Schwinge wrote:
> Hi!
> 
> On Wed, 13 Feb 2019 14:47:36 +0100, Richard Biener <richard.guenther@gmail.com> wrote:
>> On February 13, 2019 6:53:17 AM GMT+01:00, "Martin Liška" <mliska@suse.cz> wrote:
>>> As Honza noticed, there's still some leftover from MPX removal.
>>> May I remove another bunch of fields now, or should I wait
>>> for next stage1?
>>
>> You can do it now. 
> 
> I recently stumbled across an additional leftover piece:
> 
>> 2019-02-13  Martin Liska  <mliska@suse.cz>
> 
>> 	* ipa-fnsummary.c (compute_fn_summary): Likewise.
> 
> | --- a/gcc/ipa-fnsummary.c
> | +++ b/gcc/ipa-fnsummary.c
> | @@ -2449,13 +2449,7 @@ compute_fn_summary (struct cgraph_node *node, bool early)
> |        info->account_size_time (2 * ipa_fn_summary::size_scale, 0, t, t);
> |        ipa_update_overall_fn_summary (node);
> |        info->self_size = info->size;
> | -      /* We cannot inline instrumentation clones.  */
> | -      if (node->thunk.add_pointer_bounds_args)
> | -	{
> | -          info->inlinable = false;
> | -          node->callees->inline_failed = CIF_CHKP;
> | -	}
> | -      else if (stdarg_p (TREE_TYPE (node->decl)))
> | +      if (stdarg_p (TREE_TYPE (node->decl)))
> | 	{
> 
> This removed the (only) user of 'CIF_CHKP', but didn't remove its
> definition.  (Probably because of that one going by the un-prefixed
> short-hand name of 'CHKP'?)  As obvious, now cleaned up on trunk in
> r271029, and on gcc-9-branch in r271030, see attached.
> 
> 
> Grüße
>  Thomas
> 
> 

Hi.

Thanks for the patch, it's obvious to me.

Martin



More information about the Gcc-patches mailing list