[PATCH 2/2] Support {MIN,MAX}_EXPR in GIMPLE FE.

[Richard Biener]

On Tue, May 7, 2019 at 2:01 PM Martin Liška <mliska@suse.cz> wrote:
>
> On 5/6/19 1:35 PM, Richard Biener wrote:
> > On Mon, May 6, 2019 at 10:00 AM Martin Liška <mliska@suse.cz> wrote:
> >>
> >> Hi.
> >>
> >> The patch is about support of a new GIMPLE expr.
> >>
> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> >>
> >> Ready to be installed?
> >
> > Can you please avoid using/changing parser_build_binary_op?  The other
> > binary expression handling just does
> >
> >   if (lhs.value != error_mark_node && rhs.value != error_mark_node)
> >     ret.value = build2_loc (ret_loc, code, ret_type, lhs.value, rhs.value);
> >
> > which should work equally well here.  I think for future expansion
> > splitting out the ( op, op ) parsing and expression building into
> > a function might be nicer so that c_parser_gimple_unary_expression
> > reads
> >
> >   if (strcmp (INDENTIFIER_POINTER (id), "__MIN") == 0)
> >     return c_parser_gimple_parentized_binary_expression (op_loc, MIN_EXPR);
> >   else if (...)
> >
> > OK with such change/factoring.
>
> I've done all what you pointed out.

OK.

Thanks,
Richard.

> Martin
>
> >
> > Thanks,
> > Richard.
> >
> >> Thanks,
> >> Martin
>