[PATCH] Guard binary/ternary match.pd patterns to IFN_COND_* with IFN_COND_* availability (PR tree-optimization/89570)
Richard Sandiford
richard.sandiford@arm.com
Tue Mar 5 12:33:00 GMT 2019
Jakub Jelinek <jakub@redhat.com> writes:
> On Tue, Mar 05, 2019 at 09:26:19AM +0000, Richard Sandiford wrote:
>> LGTM, thanks. Given the discussion, I think it would also be worth having
>> a comment explaining why we're doing this, something like:
>>
>> /* Avoid speculatively generating a stand-alone vector comparison
>> on targets that might not support them. Any target implementing
>> conditional internal functions must support the same comparisons
>> inside and outside a VEC_COND_EXPR. */
>
> Ok, here is the patch updated with your comment.
>
> Can you please test it on aarch64 SVE? I'll test it on x86_64/i686 later
> today (maybe powerpc64{,le} too).
OK, testing passed on SVE.
Thanks,
Richard
More information about the Gcc-patches
mailing list