[RFA][tree-optimization/90883] Improve DSE to handle redundant calls

[Jeff Law]

On 6/26/19 7:14 PM, Bill Schmidt wrote:
> Looks like this patch breaks bootstrap.
> 
> /home3/wschmidt/gcc/gcc-mainline-base/gcc/tree-ssa-dse.c: In function
> 'void dse\
> _optimize_redundant_stores(gimple*)':
> /home3/wschmidt/gcc/gcc-mainline-base/gcc/tree-ssa-dse.c:649:46: error:
> ISO C++\
> Â forbids converting a string constant to 'char*' [-Werror=write-strings]
> Â  649 |Â Â  delete_dead_or_redundant_assignment (&gsi, "redundant");
> Â Â Â Â Â  |Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  ^~~~~~~~~~~
> /home3/wschmidt/gcc/gcc-mainline-base/gcc/tree-ssa-dse.c:651:40: error:
> ISO C++\
> Â forbids converting a string constant to 'char*' [-Werror=write-strings]
> Â  651 |Â Â  delete_dead_or_redundant_call (&gsi, "redundant");
> Â Â Â Â Â  |Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  ^~~~~~~~~~~
> /home3/wschmidt/gcc/gcc-mainline-base/gcc/tree-ssa-dse.c: In member
> function 'v\
> oid dse_dom_walker::dse_optimize_stmt(gimple_stmt_iterator*)':
> /home3/wschmidt/gcc/gcc-mainline-base/gcc/tree-ssa-dse.c:979:41: error:
> ISO C++\
> Â forbids converting a string constant to 'char*' [-Werror=write-strings]
> Â  979 |Â Â Â Â  delete_dead_or_redundant_call (gsi, "dead");
> Â Â Â Â Â  |Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  ^~~~~~
> /home3/wschmidt/gcc/gcc-mainline-base/gcc/tree-ssa-dse.c:1007:39: error:
> ISO C+\
> + forbids converting a string constant to 'char*' [-Werror=write-strings]
> Â 1007 |Â Â  delete_dead_or_redundant_call (gsi, "dead");
> Â Â Â Â Â  |Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  ^~~~~~
> /home3/wschmidt/gcc/gcc-mainline-base/gcc/tree-ssa-dse.c:1066:49: error:
> ISO C+\
> + forbids converting a string constant to 'char*' [-Werror=write-strings]
> Â 1066 |Â Â Â Â Â Â  delete_dead_or_redundant_assignment (gsi, "dead");
Strange as I know I've bootstrapped and tested.  I'll take care of it

Thanks,
jeff