[PATCH, v2] PowerPC: Add 'prefix' to the 'isa' attribute

Segher Boessenkool segher@kernel.crashing.org
Thu Jun 20 07:25:00 GMT 2019


Hi Mike,

On Wed, Jun 19, 2019 at 10:43:43AM -0400, Michael Meissner wrote:
> Here is version 2:
> 
> 2019-06-19  Michael Meissner  <meissner@linux.ibm.com>
> 
> 	* config/rs6000/rs6000.md (isa attribute): Add support for
> 	for a future processor.
> 
> Index: gcc/config/rs6000/rs6000.md
> ===================================================================
> --- gcc/config/rs6000/rs6000.md	(revision 272439)
> +++ gcc/config/rs6000/rs6000.md	(working copy)
> @@ -267,7 +267,8 @@ (define_attr "cpu"
>    (const (symbol_ref "(enum attr_cpu) rs6000_tune")))
>  
>  ;; The ISA we implement.
> -(define_attr "isa" "any,p5,p6,p7,p7v,p8v,p9v,p9kf,p9tf" (const_string "any"))
> +(define_attr "isa" "any,p5,p6,p7,p7v,p8v,p9v,p9kf,p9tf,futp"
> +  (const_string "any"))

Note to self: I should add a comment explaining what the values here mean.

> @@ -306,6 +307,10 @@ (define_attr "enabled" ""
>       (and (eq_attr "isa" "p9tf")
>  	  (match_test "FLOAT128_VECTOR_P (TFmode)"))
>       (const_int 1)
> +
> +     (and (eq_attr "isa" "futp")
> +	  (match_test "TARGET_FUTURE"))
> +     (const_int 1)
>      ] (const_int 0)))

Hrm, so maybe this should just be called "fut"?  (We don't yet have values
for just "p8" and "p9", nothing uses those yet, but of course we should
have those too, eventually.)

Okay for trunk with that maybe fixed.  Thanks!


Segher



More information about the Gcc-patches mailing list