*ping* Re: [PATCH] PR fortran/89103 - Allow blank format items in format strings

Jerry DeLisle jvdelisle@charter.net
Wed Jun 19 01:39:00 GMT 2019


I will see if I can get this one.

On 6/17/19 6:37 AM, Mark Eggleston wrote:
> 
> On 12/06/2019 19:11, Steve Kargl wrote:
>> On Tue, Jun 11, 2019 at 11:50:40AM +0200, Jakub Jelinek wrote:
>>> On Tue, Jun 11, 2019 at 10:30:59AM +0100, Mark Eggleston wrote:
>>>>      Jim MacArthur <jim.macarthur@codethink.co.uk>
>>>>      Mark Eggleston <mark.eggleston@codethink.com>
>>> Two spaces before < instead of one.
>>>
>>> This is not a patch review, just comments:
>> Mark, do you plan to address any of Jakub's comments.
>> Do note, I just 'OK' Jakub's patch that uses G_()
>> forms for the strings.
> 
> Now that Jakubs's patch has been committed, please find attached an updated 
> patch and updated change logs:
> 
> gcc/fortran
> 
>      Jim MacArthur  <jim.macarthur@codethink.co.uk>
>      Mark Eggleston  <mark.eggleston@codethink.com>
> 
>      PR fortran/89103
>      * gfortran.texi: Add -fdec-blank-format-item
>      * invoke.texi: Add option to list of options.
>      * invoke.texi: Add to section on Commas in FORMAT specifications.
>      * io.c (check_format): At FMT_RPAREN goto finished if
>      -fdec-blank-format-item otherwise set error string.
>      * lang.opt: Add new option.
>      * options.c (set_dec_flags): Add SET_BITFLAG for
>      flag_dec_format_defaults.
> 
> gcc/testsuite
> 
>      Jim MacArthur  <jim.macarthur@codethink.co.uk>
>      Mark Eggleston  <mark.eggleston@codethink.com>
> 
>      PR fortran/89103
>      * gfortran.dg/dec_format_empty_item_1.f: New test.
>      * gfortran.dg/dec_format_empty_item_2.f: New test.
>      * gfortran.dg/dec_format_empty_item_3.f: New test.
> 
> as before... Please can someone commit this as do not have commit rights.
> 
>>
>> Also, do you have plans to contribute additional
>> patches (either for -fdec* extensions or preferrably
>> to help with bug fixes and new features)?  It may be
>> advantageous for you to get a commit bit.
> Yes, I do intend to contribute additional patches, mostly -fdec- patches, there 
> are also some patches unrelated to -fdec* extensions.
> 
> 



More information about the Gcc-patches mailing list