[AArch64] Use scvtf fbits option where appropriate
Joel Hutton
Joel.Hutton@arm.com
Tue Jun 18 15:34:00 GMT 2019
On 18/06/2019 11:37, Richard Earnshaw (lists) wrote:
> Start sentences with a capital letter. End them with a full stop.
> "inequal" isn't a word: you probably mean "unequal".
I've fixed this, the iterator is, however defined as 'fcvt_iesize'
and described in the adjacent comment in iterators.md as 'inequal'.
I've addressed your other comments.
On 18/06/2019 13:30, Richard Sandiford wrote:
> Wilco Dijkstra <Wilco.Dijkstra@arm.com> writes:
>> > +/* If X is a positive CONST_DOUBLE with a value that is the
>> reciprocal of a
>> > + power of 2 (i.e 1/2^n) return the number of float bits. e.g.
>> for x==(1/2^n)
>> > + return n. Otherwise return -1. */
>> > +int
>> > +aarch64_fpconst_pow2_recip (rtx x)
>> > +{
>> > + REAL_VALUE_TYPE r0;
>> > +
>> > + if (!CONST_DOUBLE_P (x))
>> > + return -1;
>>> CONST_DOUBLE can be used for things other than floating point. You
>>> should really check that the mode on the double in is in class
>>> MODE_FLOAT.
>> Several other functions (eg aarch64_fpconst_pow_of_2) do the same
>> since
>> this function is only called with HF/SF/DF mode. We could add an
>> assert for
>> SCALAR_FLOAT_MODE_P (but then aarch64_fpconst_pow_of_2 should do
>> the same).
> IMO we should leave it as-is. aarch64.h has:
I've gone with the majority and left it as-is, but I don't have strong
feelings on it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-SCVTF-fbits.patch
Type: text/x-patch
Size: 10833 bytes
Desc: 0001-SCVTF-fbits.patch
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20190618/94b3e038/attachment.bin>
More information about the Gcc-patches
mailing list