indirect_ref_may_alias_decl_p fix

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Fri Jun 14 06:59:00 GMT 2019


Hi Jan,

> I am testing the following patch which solves the bogus warning in
> tree-ssa-forwprop.c and -m32 and plan to commit it as obvoius to unbreak
> bootstrap once testing converges. Previously we did not get here wince
> we got mismatch between TMR type and decl type but same code is present
> in indirect_ref_may_alias_p.
>
> Honza
>
> 	PR bootstrap/90873
> 	* tree-ssa-alias.c (indirect_ref_may_alias_decl_p): Also check that
> 	dbase is not TARGET_MEM_REF.

I've included the patch in nightly bootstraps on i386-pc-solaris2.11,
sparc-sun-solaris2.11, and i686-pc-linux-gnu.  All completed without
regressions, thanks.

One last issue, though.  The error messages totally feel like line noise
to me:

/vol/gcc/src/hg/trunk/local/gcc/tree-ssa-forwprop.c: In function 'bool simplify_rotate(gimple_stmt_iterator*)':
/vol/gcc/src/hg/trunk/local/gcc/tree-ssa-forwprop.c:1650:40: error: '#'target_mem_ref' not supported by dump_expr#<expression error>' may be used uninitialized in this function [-Werror=maybe-uninitialized]
 1650 |      if (cdef_arg2[i] == def_arg2[1 - i]
      |                          ~~~~~~~~~~~~~~^

Is this really something we mean to expose to users?

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University



More information about the Gcc-patches mailing list