[C++ Patch] Use declarator->id_loc in three additional places

Paolo Carlini paolo.carlini@oracle.com
Tue Jun 4 15:57:00 GMT 2019


On 04/06/19 16:50, Jason Merrill wrote:
> On 6/4/19 10:31 AM, Paolo Carlini wrote:
>> +          permerror (loc, "member functions are implicitly "
>> +             "friends of their class");
> Wouldn't it be better to use the location of "friend" in this diagnostic?

Yes, however doing that fully correctly seems a bit tricky, I thought 
that pointing to the id_loc it's still better than a rather meaningless 
place near the end of the line, eg, before the semicolon. Note this is a 
more general issue, I'll give it some thought... I'm leaving those 
friends alone for the time being.

Thanks, Paolo.

More information about the Gcc-patches mailing list