[PATCH] Add missing avx512dqintrin.h _mm_mask_fpclass_s[sd]_mask (PR target/89803)

Hongtao Liu crazylht@gmail.com
Tue Jun 4 09:55:00 GMT 2019


On Tue, Jun 4, 2019 at 5:21 PM Jakub Jelinek <jakub@redhat.com> wrote:
>
> On Tue, Jun 04, 2019 at 05:00:05PM +0800, Hongtao Liu wrote:
> > Thanks for reminding, Here is updated:
>
> You've missed some notes.  Ok for trunk with:
> 1) the following patch applied on top of your patch
> 2) the ChangeLog entries moved to the start of the ChangeLog (normally,
>    ChangeLog entries are not added as part of the patch, but before the
>    patch in text form, because the ChangeLog files are updated many times
>    a day
>

Ok, thanks.

> --- mask_fpclasss[sd]_v3.diff   2019-06-04 11:11:31.007712339 +0200
> +++ mask_fpclasss[sd]_v3.diff   2019-06-04 11:14:19.581047040 +0200
> @@ -2,7 +2,7 @@ Index: gcc/ChangeLog
>  ===================================================================
>  --- gcc/ChangeLog      (revision 271853)
>  +++ gcc/ChangeLog      (working copy)
> -@@ -4706,6 +4706,24 @@
> +@@ -4706,6 +4706,23 @@
>         reprocessing.  Always call df_analyze before fixing up debug bind
>         insns.
>
> @@ -12,17 +12,16 @@ Index: gcc/ChangeLog
>  +      * config/i386/avx512dqintrin.h (_mm_mask_fpclass_ss_mask,
>  +      _mm_mask_fpclass_sd_mask): New intrinsics.
>  +      (_mm_fpclass_ss_mask, _mm_fpclass_sd_mask): Modified, use new builtins.
> -+      * config/i386/i386-builtin.def
> -+      (__builtin_ia32_fpclassss_mask, __builtin_ia32_fpclasssd_mask):
> -+      New builtins.
> ++      * config/i386/i386-builtin.def (__builtin_ia32_fpclassss_mask,
> ++      __builtin_ia32_fpclasssd_mask): New builtins.
>  +      (__builtin_ia32_fpclassss, __builtin_ia32_fpclasssd): Deleted.
>  +      * config/i386/i386-builtin-types.def (DEF_FUNCTION_TYPE (QI, V2DF, INT),
>  +      DEF_FUNCTION_TYPE (QI, V4SF, INT)): Deleted.
>  +      * config/i386/i386-expand.c (case QI_FTYPE_V4SF_INT,
>  +      case QI_FTYPE_V2SF_INT): Ditto.
> -+      * config/i386/sse.md
> -+      (define_insn "avx512dq_vmfpclass<mode><mask_scalar_merge_name>):
> -+      Extended to insnstructions with mask operands.
> ++      * config/i386/sse.md (avx512dq_vmfpclass<mode>): Rename to ...
> ++      (avx512dq_vmfpclass<mode><mask_scalar_merge_name>): ... this.  Add
> ++      <mask_scalar_merge_operand3> to insn template.
>  +
>   2019-03-23  Segher Boessenkool  <segher@kernel.crashing.org>
>
> @@ -184,10 +183,10 @@ Index: gcc/testsuite/ChangeLog
>  +      (__builtin_ia32_fpclassss_mask, __builtin_ia32_fpclasssd_mask): Define.
>  +      * gcc.target/i386/avx512dq-vfpclassss-2.c: New.
>  +      * gcc.target/i386/avx512dq-vfpclasssd-2.c: New.
> -+      * gcc.target/i386/avx512dq-vfpclassss-1.c (avx512f_test):
> -+      Add test for _mm_mask_fpclass_ss_mask.
> -+      * gcc.target/i386/avx512dq-vfpclasssd-1.c (avx512f_test):
> -+      Add test for _mm_mask_fpclass_sd_mask.
> ++      * gcc.target/i386/avx512dq-vfpclassss-1.c (avx512f_test): Add test for
> ++      _mm_mask_fpclass_ss_mask.
> ++      * gcc.target/i386/avx512dq-vfpclasssd-1.c (avx512f_test): Add test for
> ++      _mm_mask_fpclass_sd_mask.
>  +
>   2019-03-22  Vladimir Makarov  <vmakarov@redhat.com>
>
>
>
>         Jakub



-- 
BR,
Hongtao



More information about the Gcc-patches mailing list