[PATCH][Preprocessor][Version 3]patch to fix PR 90581

Qing Zhao qing.zhao@oracle.com
Mon Jun 3 16:42:00 GMT 2019


Hi, Paolo,

thanks for the comment.

I will fix these issues.

Qing


> On Jun 3, 2019, at 10:03 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> 
> Hi,
> 
> a few minor comments.
> 
> On 03/06/19 16:49, Qing Zhao wrote:
>> +fmax-include-depth=
>> +C ObjC C++ ObjC++ Joined RejectNegative UInteger
>> +fmax-include-depth=<number> Set the maximum number of depth of nested #include.
> 
> I think you want something like "Set the maximum depth of nested #include".
> 
>> +@item -fmax-include-depth=@var{depth}
>> +@opindex fmax-include-depth
>> +Set the maximum number of depth of the nested include. The default is 200.
> 
> Likewise, plus include or #include?
> 
> In any case the wording should be consistent with the actual cpp_error message below in your attachment, thus, in particular, no "number".
> 
>> +  /* the maximum depths for nested #include.  */
> 
> Upper case "The". "for" or "of"? Again, consistency.
> 
> Paolo.
> 
> 



More information about the Gcc-patches mailing list