[PATCH] RX: Add rx-*-linux target

Segher Boessenkool segher@kernel.crashing.org
Sun Jun 2 17:38:00 GMT 2019


On Sun, Jun 02, 2019 at 10:12:37PM +0900, Oleg Endo wrote:
> On Sun, 2019-06-02 at 20:26 +0900, Yoshinori Sato wrote:
> > On Fri, 31 May 2019 09:16:18 +0900,
> > Jeff Law wrote:
> > > 
> > > On 5/29/19 12:27 PM, Jeff Law wrote:
> > > > On 5/23/19 6:05 AM, Yoshinori Sato wrote:
> > > > > I ported linux kernel to Renesas RX.
> > > > > 
> > > > > rx-*-elf target output a binary different from the standard
> > > > > ELF.
> > > > > It has the same format as the Renesas compiler.
> > > > > 
> > > > > But the linux kernel requires the standard ELF format.
> > > > > I want to define a rx-*-linux target so that I can generate
> > > > > a standard ELF binary.
> > > > 
> > > > Presumably you're resubmitting after your assignment got recorded
> > > > (I
> > > > think I saw that fly by recently).
> > > > 
> > > > I'll construct a ChangeLog and install this on the trunk.
> > > 
> > > So this is causing libgcc to fail to build for rx-elf.  The problem
> > > is
> > > the DF=SF #define.  I think you need so split that out so that it's
> > > only
> > > used for rx-linux.
> > > 
> > > Jeff
> > 
> > OK. fix it.
> > I tried build rx-elf target. it success.
> > 
> 
> Setting DF=SF is the wrong thing to do IMHO.  RX can do DF just fine in
> software.  If this is hardcoded like that in the roots of the
> toolchain, it will make compiling packages that actually need real DF
> completely impossible, won't it?  We also don't set DI = SI just
> because the hardware is bad at SI ... 

This is -m64bit-doubles/-m32bit-doubles, and t-rx already multilibs that?
And the default is 32-bit.  So why does rx-linux need something different?
You could make a point for wanting 64-bit doubles as default, even;
disabling it completely does not seem like a good plan.

(This patch seems to have broken rx-elf btw?)


Segher



More information about the Gcc-patches mailing list