[patch] More precise message with -Winline

Eric Botcazou ebotcazou@adacore.com
Wed Jul 24 14:39:00 GMT 2019


> Looks good besides
> 
> +         if (e->count.ipa () == profile_count::zero ())
> +           e->inline_failed = CIF_NEVER_CALL;
> 
> does it actually matter what kind of profile quality e->count.ipa has
> compared to profile_count::zero ()?

I don't really know, the other examples in the function use e->count.ipa too.

> Also
> 
> +/* Call is considered never executed.  */
> +DEFCIFCODE(NEVER_CALL, CIF_FINAL_NORMAL,
> +          N_("call is never executed and code size would grow"))
> 
> suggests the call is never executed, but we only assume that
> (or the profile training run never hit it).

OK, I added "considered" as in the comment above.

-- 
Eric Botcazou



More information about the Gcc-patches mailing list