[PATCH v4] Generalize get_most_common_single_value to return k_th value & count
luoxhu
luoxhu@linux.ibm.com
Wed Jul 17 08:46:00 GMT 2019
Hi Martin,
On 2019/7/17 15:55, Martin Liška wrote:
> On 7/17/19 7:44 AM, luoxhu wrote:
>> Hi Martin,
>> Thanks for your review, v4 Changes as below:
>> 1. Use decrease bubble sort.
>> BTW, I have a question about hist->hvalue.counters[2], when will it become
>> -1, please? Thanks. Currently, if it is -1, the function will return false.
>
> Hi.
>
> Thanks for that. I made a minor changes to your patch, please see it in attachment.
> -1 is a value that we use for invalidated histogram. That happens when you need
> to fit in more values during instrumentation than you have counters in the histogram.
> It helps to make reproducible builds of a software.
Thanks for your patience with many tiny fixes. I will install the updated
patch to trunk.
Xionghu
>
> Martin
>
More information about the Gcc-patches
mailing list