[PATCH][GCC][AArch64] Have empty HWCAPs string ignored during native feature detection

Tamar Christina Tamar.Christina@arm.com
Wed Jan 30 15:10:00 GMT 2019


Hi Jakub,

On Wed, Jan 30, 2019 at 02:06:01PM +0000, Tamar Christina wrote:
> > Thanks for the feedback, but I think those are changes for another patch.
>
> At least the memory leak is something that should be fixed even in stage4
> IMNSHO.

I'll provide a separate patch for this then.

> Anyway, will defer to aarch64 maintainers here.

> Just one question, for the *feat_string == '\0' case, is continue what you
> want, rather than just enabled = false; and doing the
 > extension_flags &= ~(aarch64_extensions[i].flag);
> later on?

Yeah, because the feature may be on by default due to another extension, in
which case you would erroneously turn it off. The absence of an HWCAPS
shouldn't pro-actively disable an extension.

Regards,
Tamar



More information about the Gcc-patches mailing list