[patch, fortran] Move some array packing to front end

Richard Biener richard.guenther@gmail.com
Thu Jan 24 11:01:00 GMT 2019


On Wed, Jan 23, 2019 at 6:18 PM Thomas Koenig <tkoenig@netcologne.de> wrote:
>
> Hi Dominique,
>
> > FAIL: gfortran.dg/internal_pack_4.f90   -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions  execution test
> >
> > with -m32.
> >
> > gfc /opt/gcc/work/gcc/testsuite/gfortran.dg/internal_pack_4.f90 -O3 -funroll-loops -ftracer -m32
> >
> > is enough to trigger the miscomputation.
>
> Thanks, I will look into it.
>
> > The changes in the test suite are quite messy and I hope I did not miss any test (you should do "diff -N …" for the new tests).
>
> I don't think this is a good idea.  Applying the patch twice will then
> double the test case.
>
>
> > Do you have test showing a speed-up?
>
> It' in the PR.
>
>
> > I agree with Richard that this patch should be held until the next stage 1.
>
> I just realized that we are, in principle, in regression-only mode.
>
> I do wish the announcements were also made to the fortran mailing lists.

They are made to the low-traffic gcc@ list which everybody working on GCC
is supposed to subscribe to.

> Anyway, I'll see if I can fix that bug, then attach the combined
> patch to the PR for later inclusion.
>
> Regards
>
>         Thomas



More information about the Gcc-patches mailing list