[PATCH 3/3][GCC][AARCH64] Add support for pointer authentication B key

Sam Tebbs Sam.Tebbs@arm.com
Wed Jan 23 10:43:00 GMT 2019


On 14/01/2019 10:43, Kyrill Tkachov wrote:

>
> On 08/01/19 11:38, Sam Tebbs wrote:
>>
>> On 1/7/19 6:28 PM, James Greenhalgh wrote:
>> > On Fri, Dec 21, 2018 at 09:00:10AM -0600, Sam Tebbs wrote:
>> >> On 11/9/18 11:04 AM, Sam Tebbs wrote:
>> >
>> > <snip>
>> >
>> >> Attached is an improved patch with "hint" removed from the test 
>> scans,
>> >> pauth_hint_num_a and pauth_hint_num_b merged into pauth_hint_num 
>> and the
>> >> "gcc_assert (cfun->machine->frame.laid_out)" removal reverted 
>> since was
>> >> an unnecessary change.
>> >>
>> >> OK for trunk?
>> > While the AArch64 parts look OK to me and are buried behind an 
>> option so are
>> > relatively safe even though we're late in development, you'll need 
>> someone
>> > else to approve the libgcc changes. Especially as you change a generic
>> > routine with an undocumented (?) AArch64-specific change.
>> >
>> > Thanks,
>> > James
>>
>> Thanks James, CC'ing Ian Lance Taylor.
>>
>
> Jeff, could you help with reviewing the libgcc changes please?
> I believe the latest version was posted at:
> https://gcc.gnu.org/ml/gcc-patches/2018-12/msg01569.html
>
> Thanks,
> Kyrill
ping 3. The preceding two patches were committed a while ago but require 
the minor libgcc changes in this patch, which are the only parts left to 
be reviewed.
>
>> The documentation relevant to the libgcc change is expected to be
>> published in the near future.


More information about the Gcc-patches mailing list