[EXT] Re: [Patch 2/4][Aarch64] v2: Implement Aarch64 SIMD ABI

Christophe Lyon christophe.lyon@linaro.org
Fri Jan 18 14:35:00 GMT 2019


On Thu, 17 Jan 2019 at 20:11, Steve Ellcey <sellcey@marvell.com> wrote:
>
> On Thu, 2019-01-17 at 09:10 +0000, Richard Sandiford wrote:
> >
> > > +static bool supported_simd_type (tree t)
> >
> > Missing line break after "static bool".
>
> Fixed.
>
> > > +static bool currently_supported_simd_type (tree t, tree b)
> >
> > Same here.
>
> Fixed.
>
> > > +          return 0;
> >
> > The return should use tab indentation.
>
> Fixed.
> >
> > OK otherwise, thanks.
> >
> > Richard
>
> Thanks for the reviews Richard, I made those changes and checked in the
> patch.  That is the last of the Aarch64 SIMD / Vector ABI patches I
> have so everything should be checked in and working now.
>

Hi Steve,

I've noticed that
FAIL: g++.dg/vect/simd-clone-7.cc  -std=c++14  (test for warnings, line 7)
(and for c++17 and c++98)
when forcing -mabi=ilp32.

I suspect you want to skip the test in this case?

Christophe

> Steve Ellcey
> sellcey@marvell.com



More information about the Gcc-patches mailing list