[PATCH] restore CFString handling in attribute format (PR 88638)

[Martin Sebor]

On 1/5/19 2:41 PM, Dominique d'Humières wrote:
> Hi Martin,
> 
> The patch on top of r267591 fixes pr88638 without regression.
> 
> Note
> 
>   FAIL: c-c++-common/attributes-4.c  -std=gnu++14 (test for excess errors)
>   FAIL: c-c++-common/attributes-4.c  -std=gnu++17 (test for excess errors)
>   FAIL: c-c++-common/attributes-4.c  -std=gnu++98 (test for excess errors)
> 
> Thanks for the fix.

I just committed it.  I don't see this test fail with my Darwin
cross-compiler.  The failures I do see in attr*.c tests are these:

FAIL: gcc.dg/attr-copy-6.c (test for excess errors)
FAIL: gcc.dg/attr-ms_struct-packed1.c (test for excess errors)
FAIL: gcc.dg/attr-weakref-1-darwin.c (test for excess errors)
FAIL: gcc.dg/attr-weakref-1.c (test for excess errors)
FAIL: c-c++-common/attr-aligned-1.c  -Wc++-compat  (test for excess errors)
XPASS: c-c++-common/attr-nonstring-3.c  -Wc++-compat  pr86688 (test for 
warnings, line 409)

The attr-copy-6.c failure is due to
   error: only weak aliases are supported in this configuration

The other FAILs are all because the tests are expected to run but
can't in this configuration.

The XPASS seems to be new and present in native builds as well so
it's something to look into.

Martin