[PATCH, fortran]: Do not cast charlen to index type in transfer_array_inner

Steve Kargl sgk@troutmask.apl.washington.edu
Tue Feb 26 19:11:00 GMT 2019


On Tue, Feb 26, 2019 at 07:16:21PM +0100, Uros Bizjak wrote:
> Attached patch removes following warning:
> 
> libgfortran/io/transfer.c: In function ‘transfer_array_inner’:
> libgfortran/io/transfer.c:2499:35: warning: operand of ?: changes
> signedness from ‘long int’ to ‘size_t’ {aka ‘long unsigned int’} due
> to unsignedness of other operand [-Wsign-compare]
> 
> There is actually no need to cast "charlen" to (unsigned) index_type,
> as it is already declared as size_t:
> 
> typedef size_t gfc_charlen_type;
> 
> the same type as are "elem_len" and "size" variables.
> 
> 2019-02-26  Uroš Bizjak  <ubizjak@gmail.com>
> 
>     * io/transfer.c (transfer_array_inner): Do not
>     cast charlen to index type.
> 
> Patch was bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
> 
> OK for mainline?
> 

Yes.

-- 
Steve



More information about the Gcc-patches mailing list