[patch, fortran] Fix PR 89174, segfault on allocate with MOLD
Steve Kargl
sgk@troutmask.apl.washington.edu
Mon Feb 25 22:45:00 GMT 2019
On Mon, Feb 25, 2019 at 01:58:27PM -0800, Steve Kargl wrote:
> On Mon, Feb 25, 2019 at 10:03:29PM +0100, Thomas König wrote:
> > Hi Steve,
> >
> > >> I think this was introduced quite some time ago, not sure if it
> > >> was ever documented anywhere. I guess we should do so.
> > >>
> > > Probably want to document this in the testcase.
> >
> > I just checked and found 77 occurences in the test suite (most of
> > them mine, to be sure). So, maybe an entry in the wiki would be
> > more appropriate.
> >
> > I am just trying to think of who introduced this (or if this
> > is even gfortran specific), but coming up blank. Does anybody
> > remember?
> >
>
> It looks like a fortuitous accident.
>
> % svn annotate gcc/testsuite/lib/gfortran-dg.exp
> 84792 tobi # look if this is dg-do-run test, in which case
> 84792 tobi # we cycle through the option list, otherwise we don't
> 84792 tobi if [expr [search_for $test "dg-do run"]] {
> 135381 janis set option_list $torture_with_loops
> 84792 tobi } else {
> 84792 tobi set option_list [list { -O } ]
> 84792 tobi }
>
> The string "dg-do run" does not match, so the torture loops are run.
>
Whoop. s/are run/are not run/
IIRC, r84792 is the earliest svn revision for gfortran.
Need to go back to the old cvs repository to find out
more.
--
Steve
20170425 https://www.youtube.com/watch?v=VWUpyCsUKR4
20161221 https://www.youtube.com/watch?v=IbCHE-hONow
More information about the Gcc-patches
mailing list