[PATCH, GCC, AArch64] Fix a couple of bugs in BTI

James Greenhalgh james.greenhalgh@arm.com
Thu Feb 21 23:00:00 GMT 2019


On Thu, Feb 21, 2019 at 06:19:10AM -0600, Sudakshina Das wrote:
> Hi
> 
> While doing more testing I found a couple of issues with my BTI patches. 
> This patch fixes them:
> 1) Remove a reference to return address key. The original patch was 
> written based on a different not yet committed patch ([PATCH 
> 3/3][GCC][AARCH64] Add support for pointer authentication B key) and I 
> missed out on cleaning this up. This is hidden behind the configuration 
> option and thus went unnoticed.
> 2) Add a missed case for adding the BTI instruction in thunk functions.
> 
> Bootstrapped on aarch64-none-linux-gnu and regression tested on 
> aarch64-none-elf with configuration turned on.

OK.

Thanks,
James

> 
> gcc/ChangeLog:
> 
> 2019-xx-xx  Sudakshina Das  <sudi.das@arm.com>
> 
> 	* config/aarch64/aarch64.c (aarch64_output_mi_thunk): Add bti
> 	instruction if enabled.
> 	(aarch64_override_options): Remove reference to return address
> 	key.
> 
> 
> Is this ok for trunk?
> Sudi



More information about the Gcc-patches mailing list