[RS6000] Fix <bd>_<mode> and <bd>tf_<mode> splitters

Segher Boessenkool segher@kernel.crashing.org
Sat Feb 16 17:15:00 GMT 2019


Hi Alan,

On Sat, Feb 16, 2019 at 10:40:24PM +1030, Alan Modra wrote:
> This patch fixes a bug that can result in "insn does not satisfy its
> constraints" if these splitters fire due to not getting ctr for the
> jump insn.  Since the jump insn can have any of r,m,d,wi,c,l as the
> decremented count output, it's not sufficient to check for
> gpc_reg_operand (which matches VSX regs for example).  Seen after
> correcting register_move_cost when the cost of gpr <-> vsx is much
> lower.  Since this is a prerequisite to fixing PR89271, I'm mentioning
> that PR in the ChangeLog.
> 
> The <bd>tf_<mode> split had a further bug in that it wouldn't match
> if the count output was m,d,wi, or l.
> 
> Bootstrapped etc. powerpc64le-linux.  OK?

Okay, thanks!  For trunk as well as backports.


Segher



More information about the Gcc-patches mailing list