[PATCH] Fix libstdc++ testsuite to handle VxWorks gthreads implementation

Jonathan Wakely jwakely@redhat.com
Fri Dec 20 10:35:00 GMT 2019


On 10/12/19 15:58 +0100, Corentin Gay wrote:
>Hello there !
>
>
>
>When implementing the support for gthreads in VxWorks, we stumbled on a
>problem in the testsuite. In the libstdc++ testsuite, we
>indiscriminately add the `-pthread` switch to the tests that require
>linking against the pthread library. In certain cases, such as VxWorks,
>the gthread interface relies on the system native threads lilbrary and 
>the `-pthread` switch does not exist.
>
>This patch adds a condition for the use of the `-pthread` switch. It
>adds it only if the target supports it. The patch also adds
>`dg-require-gthreads` in tests that were lacking it.
>
>This patch was tested on x86_64-linux and is part of our nightly testing
>on all platforms, including VxWorks.

Was it tested on AIX?

I think dg-require-gthreads will prevent the tests running for the
single-threaded multilib on AIX, so it will work OK. But there's a
chance it will need fixing. Let's wait and see (I'm currently unable
to build GCC on AIX).

OK for trunk, thanks.



More information about the Gcc-patches mailing list