[PATCH] Fix ICE in regstat_bb_compute_calls_crossed (PR rtl-optimization/92882)

Jeff Law law@redhat.com
Tue Dec 10 20:44:00 GMT 2019


On Tue, 2019-12-10 at 21:40 +0100, Jakub Jelinek wrote:
> Hi!
> 
> The following testcase ICEs on the newly added asserts.
> Some comments hint that maybe it is fine if CODE_LABEL additions
> don't
> trigger df recomputations, but even if it is not ok,
> regstat_bb_compute_calls_crossed doesn't look like an IL verification
> routine and for !NONDEBUG_INSN_P it really doesn't need
> DF_INSN_INFO_GET
> for anything, so I think it is best not to get it.
> 
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
> 
> 2019-12-10  Jakub Jelinek  <jakub@redhat.com>
> 
> 	PR rtl-optimization/92882
> 	* regstat.c (regstat_bb_compute_calls_crossed): Don't check
> 	INSN_UID against DF_INSN_SIZE or use DF_INSN_INFO_GET unless
> 	NONDEBUG_INSN_P.
> 
> 	* gfortran.dg/pr92882.f: New test.
OK
jeff
> 



More information about the Gcc-patches mailing list