[PATCH 02/10, OpenACC] Add OpenACC target kinds for decomposed kernels regions

Kwok Cheung Yeung kcy@codesourcery.com
Mon Aug 5 22:31:00 GMT 2019


I have run the whole patch series through check_GNU_style.sh and fixed 
up the formatting where indicated. Do I need to post the reformatted 
patchset?

Thanks

Kwok

On 18/07/2019 10:24 am, Jakub Jelinek wrote:
> On Wed, Jul 17, 2019 at 10:04:10PM +0100, Kwok Cheung Yeung wrote:
>> @@ -2319,7 +2339,8 @@ scan_omp_for (gomp_for *stmt, omp_context *outer_ctx)
>>       {
>>         omp_context *tgt = enclosing_target_ctx (outer_ctx);
>>
>> -      if (!tgt || is_oacc_parallel (tgt))
>> +      if (!tgt || (is_oacc_parallel (tgt)
>> +                    && !was_originally_oacc_kernels (tgt)))
>>   	for (tree c = clauses; c; c = OMP_CLAUSE_CHAIN (c))
>>   	  {
>>   	    char const *check = NULL;
> 
> Please watch up formatting, the above doesn't use tabs where it should.
> Have you run the series through contrib/check_GNU_style.sh ?
> 
> Otherwise, no concerns about this particular patch, assuming Thomas is ok
> with it.
> 
> 	Jakub
> 



More information about the Gcc-patches mailing list