[PATCH, committed] Fix comment about pcrel_external_address
Segher Boessenkool
segher@kernel.crashing.org
Thu Aug 1 20:11:00 GMT 2019
On Thu, Aug 01, 2019 at 02:38:12PM -0400, Michael Meissner wrote:
> I committed this patch as 'obvious'. As I'm preparing the next round of future
> PowerPC patches, I noticed I had a typo in the usage for the predicate
> pcrel_external_address.
> ;; Return true if the operand is an external symbol whose address can be loaded
> ;; into a register using:
> -;; PLA reg,label@pcrel@got
> +;; PLD reg,label@pcrel@got
Are you sure?
pla reg,value loads "value" into reg
pld reg,value loads the memory contents at address "value" into reg
(both use pcrel addressing, so +CIA)
pcrel_external_mem_operand does this extra indirection already?
Segher
More information about the Gcc-patches
mailing list