[PATCH] RX: Add rx-*-linux target

Jeff Law law@redhat.com
Tue Apr 30 15:54:00 GMT 2019


On 4/30/19 7:55 AM, Yoshinori Sato wrote:
> On Tue, 30 Apr 2019 06:48:01 +0900,
> Jeff Law wrote:
>>
>> On 3/26/19 8:21 AM, Yoshinori Sato wrote:
>>> I ported linux kernel to Renesas RX.
>>>
>>> rx-*-elf target output a binary different from the standard ELF.
>>> It has the same format as the Renesas compiler.
>>>
>>> But the linux kernel requires the standard ELF format.
>>> I want to define a rx-*-linux target so that I can generate
>>> a standard ELF binary.I believe you have a copyright assignment on file for your H8 work.  Was
>> the assignment specific to the H8 or was it more general?
> 
> No. This changes other target.
> These files are not included in my copyright assignment.
> 
>>
>>> diff --git a/gcc/config/rx/linux.h b/gcc/config/rx/linux.h
>>> new file mode 100644
>>> index 00000000000..69500a379f2
>>> --- /dev/null
>>> +++ b/gcc/config/rx/linux.h
>>
>>> +
>>> +/* This is how to output an element of a case-vector that is relative.
>>> +   Note: The local label referenced by the "3b" below is emitted by
>>> +   the tablejump insn.  */
>>> +
>>> +#undef ASM_OUTPUT_ADDR_DIFF_ELT
>>> +#define ASM_OUTPUT_ADDR_DIFF_ELT(FILE, BODY, VALUE, REL) \
>>> +  fprintf (FILE, "\t.long .L%d - 1b\n", VALUE)
>> Note the comment references "3b", but the output is "1b".
> 
> Oh.
> I will update it.
> 
>> I don't see anything in here significantly concerning.  We just need to
>> verify your copyright assignment status.
> 
> OK.
> 
>> Also, do you have write access to the repo?
> 
> I don't have write permission of svn repository.
OK.  So let me know when the assignment is updated and I'll commit the
changes.

If you forsee doing future work, you might consider a broader assignment
so that we don't have to go through the assignment process for each
contribution.

Jeff



More information about the Gcc-patches mailing list