[PATCH] Fix tests that fail with _GLIBCXX_USE_CXX11_ABI=0

Jakub Jelinek jakub@redhat.com
Fri Apr 26 16:43:00 GMT 2019


On Fri, Apr 26, 2019 at 04:02:00PM +0100, Jonathan Wakely wrote:
> The pmr::string typedef isn't available for the old COW string, so some
> tests that use it were failing.
> 
> 	* testsuite/20_util/variant/run.cc: Use a new Hashable type to test
> 	hashing, because pmr::string depends on _GLIBCXX_USE_CXX11_ABI==1.
> 	* testsuite/21_strings/basic_string/hash/hash.cc
> 	[!_GLIBCXX_USE_CXX11_ABI]: Don't test pmr strings.
> 	* testsuite/21_strings/basic_string/hash/hash_char8_t.cc
> 	[!_GLIBCXX_USE_CXX11_ABI]: Likewise.
> 
> Tested x86_64-linux, committed to trunk.
> 
> I'd like to backport this to gcc-9-branch too, so all the tests pass
> for the old string ABI.

Ok for 9.1, it is testsuite only.

> commit 3161225fb11a655a3921a7a2a9f5b7cc53c7fa9e
> Author: Jonathan Wakely <jwakely@redhat.com>
> Date:   Fri Apr 26 15:59:53 2019 +0100
> 
>     Fix tests that fail with _GLIBCXX_USE_CXX11_ABI=0
>     
>     The pmr::string typedef isn't available for the old COW string, so some
>     tests that use it were failing.
>     
>             * testsuite/20_util/variant/run.cc: Use a new Hashable type to test
>             hashing, because pmr::string depends on _GLIBCXX_USE_CXX11_ABI==1.
>             * testsuite/21_strings/basic_string/hash/hash.cc
>             [!_GLIBCXX_USE_CXX11_ABI]: Don't test pmr strings.
>             * testsuite/21_strings/basic_string/hash/hash_char8_t.cc
>             [!_GLIBCXX_USE_CXX11_ABI]: Likewise.

	Jakub



More information about the Gcc-patches mailing list