[PATCH] PR bootstrap/87338: Fix ia64 bootstrap comparison regression in r257511

Jeff Law law@redhat.com
Fri Apr 26 14:27:00 GMT 2019


On 4/26/19 2:01 AM, Jakub Jelinek wrote:
> On Fri, Apr 26, 2019 at 08:58:18AM +0200, Richard Biener wrote:
>> On Thu, Apr 25, 2019 at 7:52 PM James Clarke <jrtc27@jrtc27.com> wrote:
>>>
>>> By using ASM_OUTPUT_LABEL, r257511 forced the assembler to start a new
>>> bundle when emitting an inline entry label on. Instead, use
>>> ASM_OUTPUT_DEBUG_LABEL like for the block begin and end labels so tags are
>>> emitted rather than labels.
>>
>> Looks sensible.  mips is the other port defining ASM_OUTPUT_DEBUG_LABEL,
>> so either you can do a bootstrap/test on mips as well or I'm asking Matthew
>> for approval here.
> 
> And arm and arc, while they don't define their own ASM_OUTPUT_DEBUG_LABEL,
> they override TARGET_ASM_INTERNAL_LABEL which is the underlying
> implementation of the default ASM_OUTPUT_DEBUG_LABEL.  But I agree that
> for mips it is a significant change, while arm and arc call default_internal_label
> from their hook, just do additional stuff.
My tester will bootstrap the mips port within 24hrs after the change is
committed.  Happy to contact y'all if something goes wrong ;-)  If you
don't hear from me, assume it didn't cause problems.

Jeff



More information about the Gcc-patches mailing list