[9/10 PATCH] Update {x86_64,i?86,powerpc64,s390x,aarch64}-linux baseline_symbols.txt files

[Jonathan Wakely]

On 26/04/19 14:36 +0100, Jonathan Wakely wrote:
>On 26/04/19 14:30 +0200, Jakub Jelinek wrote:
>>On Fri, Apr 26, 2019 at 01:25:37PM +0100, Jonathan Wakely wrote:
>>>On 26/04/19 12:48 +0200, Jakub Jelinek wrote:
>>>> Hi!
>>>>
>>>> The following patch updates the baseline symbols files from April 18th
>>>> Fedora rpm build.  I've verified the only added lines are for the
>>>> GLIBCXX_3.4.26 or CXXABI_1.3.12 symvers and I don't see any new long double
>>>> symbol on powerpc64 or s390x, except I had to manually remove
>>>> FUNC:_ZNSbIwSt11char_traitsIwESaIwEE19_M_replace_dispatchIPKcEERS2_N9__gnu_cxx17__normal_iteratorIPwS2_EESA_T_SB_St12__false_type@@GLIBCXX_3.4
>>>> lines that started to appear on all but s390x builds in Fedora rpm builds
>>>> (but they don't show up e.g. on my workstation).  Guess we need to make the
>>>> wildcards more careful.
>>>
>>>The attached patch would do that. The symbol above is a function
>>>template, so we don't need to export it from the lib (because user
>>>code that needs it will instantiate it anyway). It's only called from
>>>the basic_string<C,T,A>::replace<Iter>(iterator, iterator, Iter, Iter)
>>>function template, which isn't exported from the lib.
>>
>>Thanks, LGTM.
>>grep _ZNSbIwSt11char_traitsIwESaIwEE.*_M_replace libstdc++-v3/config/abi/post/*/{,*/}*.txt | grep -v _ZNSbIwSt11char_traitsIwESaIwEE14_M_replace_aux | grep -v _ZNSbIwSt11char_traitsIwESaIwEE15_M_replace_safe
>>prints nothing, so the patch looks correct and safe.
>>
>>Ok for 9.1.
>
>I tracked down where that symbol was being instantiated, and it's not
>needed anyway, and can be suppressed by using if-constexpr. Here's
>what I'm going to commit for trunk (after testing finishes).
>
>This should be safe for the branch too, but we can just make the
>linker script change for now and backport this for 9.2 once it's been
>on trunk for a while.

Here's the final patch I tested and committed to trunk (I had to
replace std::-si_same_v with std::is_same because the
<bits/locale_conv.h> header is used in C++11 and C++14 too).


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.txt
Type: text/x-patch
Size: 3496 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20190426/54ecdc17/attachment.bin>