[PATCH v2] Add error message for target_clones and AVX512 ISAs (PR target/89929).

H.J. Lu hjl.tools@gmail.com
Thu Apr 25 16:59:00 GMT 2019


On Thu, Apr 25, 2019 at 1:03 AM Uros Bizjak <ubizjak@gmail.com> wrote:
>
>
>
> On Thu, Apr 25, 2019 at 9:51 AM Martin Liška <mliska@suse.cz> wrote:
>>
>> On 4/23/19 10:29 AM, Martin Liška wrote:
>> > On 4/18/19 7:44 PM, H.J. Lu wrote:
>> >> On Thu, Apr 18, 2019 at 4:07 AM Martin Liška <mliska@suse.cz> wrote:
>> >>>
>> >>> Hi.
>> >>>
>> >>> I'm sending updated version of that patch. The patch rejects usage of AVX512 ISAs (except AVX512F)
>> >>> for target attribute for C++ multiversioning and for target_clone attribute.
>> >>>
>> >>> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
>> >>>
>> >>> Ready to be installed?
>> >>> Thanks,
>> >>> Martin
>> >>
>> >> Your patch doesn't handle cmov nor gfni properly, which aren't AVX512.
>> >> I prefer this patch.
>> >>
>> >
>> > I like the patch. Thanks for working on that.
>> >
>> > Martin
>> >
>> >
>>
>> Btw. can we get that patch into GCC 9.1?
>>
>> Adding port maintainers to CC.
>
>
> HJ knows ISA interdependencies, and the benefit of the patch outweights the (small) risk, so from the maintaner PoV, OK for the mainline unless RM vetoes the decision soon. HJ, please double check the patch for eventual inconsistencies or possible regressions before committing.
>
> Thanks,
> Uros.

Tested on x86-64.  I am checking in this updated patch with:

diff --git a/gcc/testsuite/g++.target/i386/pr57362.C b/gcc/testsuite/g++.target/
i386/pr57362.C
index 5e612130357..ced5e518cfe 100644
--- a/gcc/testsuite/g++.target/i386/pr57362.C
+++ b/gcc/testsuite/g++.target/i386/pr57362.C
@@ -199,4 +199,4 @@ int foo(void) { return 1; }
 /* { dg-prune-output "attribute.* is unknown" } */
 /* { dg-prune-output "missing 'target' attribute*" } */
 /* { dg-prune-output "redefinition of 'int foo" } */
-/* { dg-prune-output "no dispatcher found for" } */
+/* { dg-prune-output "ISA '.*' is not supported in 'target' attribute" } */


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x86-Update-message-for-target_clones-and-unsupported.patch
Type: text/x-patch
Size: 20488 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20190425/a749df8c/attachment.bin>


More information about the Gcc-patches mailing list