[PATCH, PR d/90086] Fix linker warning and SEGV in core.thread tests

Rainer Orth ro@CeBiTec.Uni-Bielefeld.DE
Thu Apr 25 12:54:00 GMT 2019


Hi Iain,

> This patch removes the monolithic and cumbersome to maintain
> core/threadasm.S, and splitted it into multiple parts, one for each
> intended target cpu/os.
>
> Added .type and .size directives for all asm implementations of
> fiber_switchContent and callWithStackShell where they were missing,
> fixing the last remaining failing test on -m32 that I can reproduce
> locally.
>
> Bootstrapped and regression tested on x86_64-linux-gnu with multilibs
> -m32, -mx32, and -m64.
>
> Committed to trunk as r270560.

this patch badly broke x86 libphobos testing, as noticed during a
i386-pc-solaris2.11 build.  All link tests FAIL like this:

FAIL: libphobos.cycles/mod1.d --DRT-oncycle=print (test for excess errors)
Excess errors:
Undefined                       first referenced
 symbol                             in file
fiber_switchContext                 /var/gcc/gcc-9.0.1-20190425/11.5-gcc-gas-libphobos/i386-pc-solaris2.11/libphobos/libdruntime/.libs/libgdruntime.a(thread.o)
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status

UNRESOLVED: libphobos.cycles/mod1.d --DRT-oncycle=print compilation failed to produce executable

You need to quote brackets to get them from m4/autoconf macros into
configure.  Fixed as follows, tested on i386-pc-solaris2.11, installed
as obvious.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2019-04-25  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	* m4/druntime/cpu.m4 (DRUNTIME_CPU_SOURCES): Quote brackets.
	* configure: Regenerate.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: x86-libphobos-druntime-cpu.patch
Type: text/x-patch
Size: 872 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20190425/3fddddb8/attachment.bin>


More information about the Gcc-patches mailing list