[RFC] D support for S/390

Robin Dapp rdapp@linux.ibm.com
Thu Apr 18 15:04:00 GMT 2019


Hi Rainer,

> I noticed you missed one piece of Iain's typeinfo.cc patch, btw.:
> 
> diff --git a/gcc/d/typeinfo.cc b/gcc/d/typeinfo.cc
> --- a/gcc/d/typeinfo.cc
> +++ b/gcc/d/typeinfo.cc
> @@ -886,7 +886,7 @@ public:
>  	if (cd->isCOMinterface ())
>  	  flags |= ClassFlags::isCOMclass;
>  
> -	this->layout_field (build_integer_cst (flags));
> +	this->layout_field (build_integer_cst (flags, d_uint_type));
>  
>  	/* void *deallocator;
>  	   OffsetTypeInfo[] m_offTi;  (not implemented)

thanks for catching this.  I amended the patch and ran the D test suite
on S/390 and i386 one more time.

For S/390 the number of FAILs is unchanged

                === libphobos Summary ===

# of expected passes            380
# of unexpected failures        30

Some of the FAILs are still a little worrying, like tests for "-shared"
which I haven't looked at at all so far.  Still, it's better than the
>200 before.

On i386 I see no FAILs with the patch.

Regards
 Robin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dlang-phobos-v3.diff
Type: text/x-patch
Size: 14136 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20190418/b3105f01/attachment.bin>


More information about the Gcc-patches mailing list