[PATCH] backport r257541, r259936, r260294, r260623, r261098, r261333, r268585.

Segher Boessenkool segher@kernel.crashing.org
Tue Apr 16 11:45:00 GMT 2019


Hi Xiong,

Sorry I took so long to review this.

On Thu, Apr 04, 2019 at 02:49:29AM -0500, luoxhu@linux.ibm.com wrote:
> These patches are followed changes for r255555 on testcases
> vsx-vector-6*.c.  backport them to update file names and fix regressions
> for GCC7 on power9.

(See e.g. https://gcc.gnu.org/ml/gcc-testresults/2019-04/msg01868.html for
the failures this patch fixes; the patch is for GCC 7).

> gcc/ChangeLog:
> 
> 2019-04-03  Xiong Hu Luo <luoxhu@linux.ibm.com>
> 
> 	backport from trunk r260623.
> 
> 	2018-05-23  Segher Boessenkool  <segher@kernel.crashing.org>
> 
> 	* doc/sourcebuild.texi (Endianness): New subsubsection.

We write the changelog like

2019-04-16  Xiong Hu Luo <luoxhu@linux.ibm.com>

	Backport from trunk
	2018-05-23  Segher Boessenkool  <segher@kernel.crashing.org>

	* doc/sourcebuild.texi (Endianness): New subsubsection.

(no revision number, capital on Backport, no empty line after it).

> 2019-04-03  Xiong Hu Luo <luoxhu@linux.ibm.com>
> 
> 	backport from trunk r257541.
> 
> 	2018-02-07  Will Schmidt  <will_schmidt@vnet.ibm.com>
> 
> 	* gcc.target/powerpc/vsx-vector-6-le.c:  Update CPU target.
> 	* gcc.target/powerpc/vsx-vector-6-le.p9.c:  New.

Only one space after : please.

> 	2018-05-04 Carl Love  <cel@us.ibm.com>

Two spaces between date and name.

> 	* gcc.target/powerpc/vsx-vector-6-le.c: Add le qualifiers as needed for
> 	the various instruction counts.  Rename file to	vsx-vector-6.p8.c.

There's a tab after "to" here, should be a space.


Other than those nits, okay for the GCC 7 branch, thanks!

("be" and "le" are essentially PowerPC-specific selectors on the 7 branch,
otherwise you'd need a release manager's approval as well).


Segher



More information about the Gcc-patches mailing list