[PATCH] Handle multiple 'default' in target attribute (PR middle-end/89970).

Jakub Jelinek jakub@redhat.com
Thu Apr 11 10:58:00 GMT 2019


On Thu, Apr 11, 2019 at 12:44:40PM +0200, Martin Liška wrote:
> On 4/11/19 11:57 AM, Richard Biener wrote:
> > On Thu, Apr 11, 2019 at 10:37 AM Martin Liška <mliska@suse.cz> wrote:
> >>
> >> Hi.
> >>
> >> The patch is catching duplicate 'default' values in target attribute.
> >>
> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> >>
> >> Ready to be installed?
> > 
> > I wonder if it isn't better to ignore duplicate "default"s (given you needed to
> > adjust a testcase even)?
> 
> Well, possibly yes. But I would prefer to have a more strict checking.

I agree, default, default is not really useful and rejecting it is fine.
Having a testcase covering that is of course desirable.

	Jakub



More information about the Gcc-patches mailing list