[PATCH] Fix PR83033
Richard Earnshaw (lists)
Richard.Earnshaw@arm.com
Sat Apr 6 11:00:00 GMT 2019
On 06/04/2019 00:00, Richard Earnshaw (lists) wrote:
> On 05/04/2019 16:53, Andrea Corallo wrote:
>>
>> Richard Earnshaw (lists) writes:
>>
>>> On 29/03/2019 11:01, Andrea Corallo wrote:
>>>> Hi all,
>>>> simple patch addressing minor style issue into gcc/config/aarch64/cortex-a57-fma-steering.c.
>>>>
>>>> make BOOT_CFLAGS='-mcpu=cortex-a57' bootstrap
>>>>
>>>> Okay for trunk?
>>>>
>>>> Bests
>>>> Andrea
>>>>
>>>>
>>>> 2019-03-29 Andrea Corallo <andrea.corallo@arm.com>
>>>>
>>>> PR target/83033
>>>> * config/aarch64/cortex-a57-fma-steering.c
>>>> (fma_forest): Fix missing copy constructor.
>>>> (fma_root_node): Likewise.
>>>> (func_fma_steering): Likewise.
>>>>
>>>
>>> These should be commented, even if it's as simple as "Prohibit copy
>>> construction."
>>>
>>> R.
>>
>>>
>>>>
>>
>> Hi Richard,
>> here we go.
>>
>
> Really? I don't see any change since the last version... :-(
>
Ah, you've just changed the ChangeLog entries. By comments, I meant in
the source code, so that it's clear these don't exist. ChangeLog update
is good too.
R.
> R.
>
>> Bests
>> Andrea
>>
>> 2019-03-29 Andrea Corallo <andrea.corallo@arm.com>
>>
>> PR target/83033
>> * config/aarch64/cortex-a57-fma-steering.c
>> (fma_forest): Prohibit copy construction.
>> (fma_root_node): Prohibit copy construction.
>> (func_fma_steering): Prohibit copy construction.
>>
>
More information about the Gcc-patches
mailing list