[PATCH 21/25] GCN Back-end (part 2/2).

[Joseph Myers]

On Wed, 12 Sep 2018, Andrew Stubbs wrote:

> > I'd expect this to fail on non-Unix configurations that don't have -ldl,
> > and thus to need appropriate conditionals / configure tests to avoid that
> > build failure.
> 
> The attached diff from the previous patch should address these issues, I hope.
> If they're OK I'll incorporate the changes into the next version of the (much)
> larger patch when I next post them.

> +	case "$host" in
> +	x86_64*-*-linux-gnu )
> +		if test "$ac_res" != no; then
> +			extra_programs="${extra_programs} gcn-run\$(exeext)"
> +		fi

ac_res is a generic autoconf variable used by a lot of tests.  I don't 
think it's at all safe to embed an assumption into the middle of 
config.gcc about which the last test run that sets such a variable is; you 
need a variable explicitly relating to whatever the relevant test is.

What if the host is x86_64 with the x32 ABI?  If the requirement is for 
various types to be the same between the host and GCN, I'd expect that x32 
ABI on the host means it is unsuitable for using gcn-run.  Or are the 
requirements for compatible types between some other two pieces, so that 
an x32 gcn-run is OK?

-- 
Joseph S. Myers
joseph@codesourcery.com