[PATCH 21/25] GCN Back-end (part 2/2).

[Andrew Stubbs]

On 05/09/18 15:22, Joseph Myers wrote:
> In cases like this with alternative diagnostic messages using ?:, you need
> to mark up each message with G_() so they both get extracted for
> translation by exgettext.
> 
[...]
> 
> This concatenation with a macro won't work with exgettext extracting
> messages for translation.
> 
[...]
> 
> Use %qs (presuming this code is using the generic diagnostic machinery
> that supports it).
> 
> +gcn-run$(exeext): gcn-run.o
> +       +$(LINKER) $(ALL_LINKERFLAGS) $(LDFLAGS) -o $@ $< -ldl
> 
> I'd expect this to fail on non-Unix configurations that don't have -ldl,
> and thus to need appropriate conditionals / configure tests to avoid that
> build failure.

The attached diff from the previous patch should address these issues, I 
hope. If they're OK I'll incorporate the changes into the next version 
of the (much) larger patch when I next post them.

> A new port should add an appropriate entry to contrib/config-list.mk.

I'm still testing this.

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 180912-fix-gcn-review-issues.patch
Type: text/x-patch
Size: 7726 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20180912/c741503c/attachment.bin>