Is the D frontend good to go? (was Re: [PATCH 02/14] Add D frontend (GDC) implementation.)
David Malcolm
dmalcolm@redhat.com
Thu Oct 25 14:12:00 GMT 2018
On Tue, 2018-10-23 at 19:21 +0200, Iain Buclaw wrote:
> On Tue, 23 Oct 2018 at 15:48, Richard Sandiford
> <richard.sandiford@arm.com> wrote:
> >
> > Iain Buclaw <ibuclaw@gdcproject.org> writes:
> > > I'm just going to post the diff since the original here, just to
> > > show
> > > what's been done since review comments.
> > >
> > > I think I've covered all that's been addressed, except for the
> > > couple
> > > of notes about the quadratic parts (though I think one of them is
> > > actually O(N^2)). I've raised bug reports on improving them
> > > later.
> > >
> > > I've also rebased them against trunk, so there's a couple new
> > > things
> > > present that are just to support build.
> >
> > Thanks, this is OK when the frontend is accepted in principle
> > (can't remember where things stand with that).
> >
>
> As discussed, the front-end has already been approved by the SC.
>
> I'm not sure if there's anything else further required, or if any
> final review needs to be done.
>
> Thanks.
I'm wondering what the state of this is [1]
Iain: are all of the patches individually approved, with the necessary
issues fixed?
IIRC, the front-end as a whole was approved, pending approval of all of
the individual patches (URL?). If that's done, then presumably this is
good to go in - unless there was still some license discussion pending?
I take it that you've already got your contributor paperwork in place,
right? I see from your maintainers commit that you presumably have svn
access.
I'm not a global reviewer or steering committee member though; would be
nice to get a "go for it" from one of those. Richard is a global
reviewer.
I'm not sure if it should be one big mega-commit, or split out the same
way you split things out for review.
Thanks for all your work on this
Dave
[1] I've been checking the git mirror every few hours to look for a
massive commit from you, if I'm honest :)
More information about the Gcc-patches
mailing list