[PATCH] Adjust offsets for present data clauses

[Thomas Schwinge]

Hi Julian!

On Fri, 30 Nov 2018 10:37:09 +0000, Julian Brown <julian@codesourcery.com> wrote:
> > On 2018/7/21 6:07 AM, Cesar Philippidis wrote:
> > > This is another old gomp4 patch that corrects a bug where the
> > > runtime was passing the wrong offset for subarray data to the
> > > accelerator. The original description of this patch can be found
> > > here <https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01676.html>

> This one will be superseded

Well, this is clearly a bug, so should be addressed independently.  I
just filed <https://gcc.gnu.org/PR88288> "[OpenACC, libgomp] Adjust
offsets for present data clauses".  (Better late than never...)

> by the attach/detach patch, I think (where
> the additional offset is added also, via calling "gomp_map_val".

Aha, good to know: during review, I wondered about whether that function
should actually be used.  (But it also isn't in other places in
"libgomp/target.c".)


Grüße
 Thomas