[PATCH 4/4][libbacktrace] Add tests for unused formats

[Tom de Vries]

On 29-11-18 19:28, Ian Lance Taylor wrote:
> On Fri, Nov 23, 2018 at 12:56 PM, Tom de Vries <tdevries@suse.de> wrote:
>>
>> When building libbacktrace, we typically use elf.c, and don't build pecoff.c,
>> xcoff.c or unknown.c
>>
>> Add testcases that use unused format to ensure that we also build and
>> test those on a typical development setup.
>>
>> Bootstrapped and reg-tested on x86_64.
>>
>> OK for trunk?
>>
>> Thanks,
>> - Tom
>>
>> [libbacktrace] Add tests for unused formats
>>
>> 2018-11-23  Tom de Vries  <tdevries@suse.de>
>>
>>         * configure.ac (NOT_HAVE_FORMAT_ELF, NOT_HAVE_FORMAT_PECOFF)
>>         (NOT_HAVE_FORMAT_UNKNOWN, NOT_HAVE_FORMAT_XCOFF_32)
>>         (NOT_HAVE_FORMAT_XCOFF_64): New AM_CONDITIONAL.
>>         * configure: Regenerate.
>>         * Makefile.am (check_PROGRAMS): Add test_elf, test_xcoff_32,
>>         test_xcoff_64, test_pecoff and test_unknown.
>>         * Makefile.in: Regenerate.
>>         * test_format.c: New file.
> 
> 
> Again it seems feasible to avoid GNU make features, and skip the
> negative conditionals and just build the tests for all formats
> including the one on the current system.  It's not worth adding the
> complexity to avoid building the test.  Thanks.

Done.

OK for trunk?

Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-libbacktrace-Add-tests-for-unused-formats.patch
Type: text/x-patch
Size: 15653 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20181130/7703acc7/attachment.bin>