[PATCH 1/5][libbacktrace] Factor out backtrace_vector_free

Tom de Vries tdevries@suse.de
Thu Nov 29 12:33:00 GMT 2018


On 29-11-18 00:26, Ian Lance Taylor wrote:
> On Wed, Nov 28, 2018 at 3:15 PM, Tom de Vries <tdevries@suse.de> wrote:
>>
>> this patch factors out new function backtrace_vector_free.
>>
>> Bootstrapped and reg-tested on x86_64.
>>
>> OK for trunk?
> 
> We should only add new files if we really absolutely must, as this
> package is copied around to a lot of places (e.g.,
> libsanitizer/libbacktrace) and adding files here requires
> modifications in all those places.
> 

I see, thanks for the explanation.

How about his patch? It does not add a file, though it does add an
external function which requires a rename in libsanitizer/libbacktrace
(I don't know whether that requires changes in any other places).

[ Also, it inlines backtrace-vector.c into alloc.c and mmap.c, so it
duplicates code. If that is not acceptable, I could move it to
internal.h as static inline or static ATTRIBUTE_UNUSED. ]

Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libbacktrace-Factor-out-backtrace_vector_free.patch
Type: text/x-patch
Size: 4006 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20181129/51b2fa03/attachment.bin>


More information about the Gcc-patches mailing list