Don't use %z printf format length specified

Richard Biener richard.guenther@gmail.com
Thu Nov 15 10:08:00 GMT 2018


On Wed, Nov 14, 2018 at 6:24 PM Michael Matz <matz@suse.de> wrote:
>
> Hi,
>
> On Wed, 14 Nov 2018, Alexander Monakov wrote:
>
> > On Wed, 14 Nov 2018, Michael Matz wrote:
> >
> > > Hi,
> > >
> > > it's not c++98 conforming and I get 1 million warnings when compiling.
> > > Initially I had also casts to long at the various arguments, but I get no
> > > warning with this variant either, so I removed them again.  I'm currently
> > > regstrapping this, okay for trunk if successfull?
> >
> > Surely this will break mingw-w64 where size_t is 64-bit yet long is 32-bit?
>
> Okay, probably.  Then consider the same patch with sprinkling casts to
> long for all these arguments (the actual numbers will fit that type in
> reality).  I could of course also use PRIu64 but that makes my eyes bleed.

Hmm.  Can you use PRIu64 please and cast to uint64_t?  OK with that
change.

Thanks,
Richard.

>
> Ciao,
> Michael.



More information about the Gcc-patches mailing list