[PATCH 1/7][MSP430][TESTSUITE] Tweak dg-directives for msp430-elf
Paul Koning
paulkoning@comcast.net
Wed Nov 14 18:50:00 GMT 2018
> On Nov 14, 2018, at 1:00 PM, Jozef Lawrynowicz <jozef.l@mittosystems.com> wrote:
>
> On 14/11/2018 16:54, Andreas Schwab wrote:
>> On Nov 14 2018, Jozef Lawrynowicz <jozef.l@mittosystems.com> wrote:
>>
>>> diff --git a/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c b/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c
>>> index 6b1c427..71d24ce 100644
>>> --- a/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c
>>> +++ b/gcc/testsuite/c-c++-common/torture/builtin-arith-overflow-10.c
>>> @@ -1,6 +1,7 @@
>>> /* Test __builtin_{add,sub}_overflow on {,un}signed long int. */
>>> /* { dg-do run } */
>>> /* { dg-skip-if "" { ! run_expensive_tests } { "*" } { "-O0" "-O2" } } */
>>> +/* { dg-timeout 120 { target msp430-*-* } } */
>> Are you sure you want to _decrease_ the timeout? The default is 300
>> seconds.
>>
>> Andreas.
>>
> The timeout as set in the dejagnu configuration for msp430 ([dejagnu.git]/baseboards/msp430-sim.exp) is 30, which is rarely hit. There are some tests which pass most of of the time but will occasionally timeout so maybe the default timeout in dejagnu is worth increasing a little as well.
Would it make sense to use { dg-timeout-factor 4 ... } instead? That would make it explicit that you're raising rather than lowering the timeout.
paul
More information about the Gcc-patches
mailing list