record_ranges_from_incoming_edge: use value_range API for creating new range

Richard Biener richard.guenther@gmail.com
Thu Nov 8 14:25:00 GMT 2018


On Thu, Nov 8, 2018 at 1:17 PM Aldy Hernandez <aldyh@redhat.com> wrote:
>
> This one's rather obvious and does not depend on any get_range_info API
> change.
>
> OK for trunk?

Hmm, no - that's broken.  IIRC m_equiv are shared bitmaps if you
do tem = *old_vr so you modify it in place with equiv_clear().

Thus, operator= should be really deleted or mapped to value_range::set()
in which case tem = *old_vr would do useless bitmap allocation and
copying that you then clear.

It's also two lines of code instead of one.

Richard.



More information about the Gcc-patches mailing list